Skip to content

fix: menu and post category dragging issue #7608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 30, 2025

What type of PR is this?

/area ui
/kind bug
/milestone 2.21.x

What this PR does / why we need it:

Fix issue where menu items and post categories could not be reordered via drag-and-drop

Which issue(s) this PR fixes:

Fixes #7607

Does this PR introduce a user-facing change?

修复菜单项和文章分类可能出现无法拖动排序的问题

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 30, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.21.x milestone Jun 30, 2025
@f2c-ci-robot f2c-ci-robot bot requested a review from LIlGG June 30, 2025 04:56
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 30, 2025
@f2c-ci-robot f2c-ci-robot bot requested a review from wan92hen June 30, 2025 04:56
Copy link

Copy link

codecov bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.64%. Comparing base (42c374d) to head (a668f17).
Report is 96 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7608      +/-   ##
============================================
+ Coverage     59.55%   59.64%   +0.08%     
+ Complexity     3812     3788      -24     
============================================
  Files           677      676       -1     
  Lines         23248    23077     -171     
  Branches       1500     1483      -17     
============================================
- Hits          13846    13764      -82     
+ Misses         8764     8678      -86     
+ Partials        638      635       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2025
Copy link

f2c-ci-robot bot commented Jul 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit 3dd0d00 into halo-dev:main Jul 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

后台菜单管理单击问题
2 participants