Skip to content

feat: add details extension for editor #7594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 26, 2025

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 26, 2025

What type of PR is this?

/area ui
/area editor
/kind feature
/milestone 2.21.x

What this PR does / why we need it:

Add details supports for editor.

image

Which issue(s) this PR fixes:

Fixes #3490

Special notes for your reviewer:

Does this PR introduce a user-facing change?

为编辑器添加内容折叠功能

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI labels Jun 26, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.21.x milestone Jun 26, 2025
@f2c-ci-robot f2c-ci-robot bot requested a review from guqing June 26, 2025 08:09
@f2c-ci-robot f2c-ci-robot bot added the area/editor Issues or PRs related to the Editor label Jun 26, 2025
@f2c-ci-robot f2c-ci-robot bot requested a review from JohnNiang June 26, 2025 08:09
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 26, 2025
@ruibaby ruibaby changed the title feat: add details extension for editor WIP:feat: add details extension for editor Jun 26, 2025
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2025
Copy link

pkg-pr-new bot commented Jun 26, 2025

Open in StackBlitz

@halo-dev/api-client

npm i https://pkg.pr.new/@halo-dev/api-client@7594

@halo-dev/components

npm i https://pkg.pr.new/@halo-dev/components@7594

@halo-dev/richtext-editor

npm i https://pkg.pr.new/@halo-dev/richtext-editor@7594

@halo-dev/console-shared

npm i https://pkg.pr.new/@halo-dev/console-shared@7594

@halo-dev/ui-plugin-bundler-kit

npm i https://pkg.pr.new/@halo-dev/ui-plugin-bundler-kit@7594

commit: bdecb97

Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.64%. Comparing base (42c374d) to head (bdecb97).
Report is 84 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7594      +/-   ##
============================================
+ Coverage     59.55%   59.64%   +0.08%     
+ Complexity     3812     3788      -24     
============================================
  Files           677      676       -1     
  Lines         23248    23077     -171     
  Branches       1500     1483      -17     
============================================
- Hits          13846    13764      -82     
+ Misses         8764     8678      -86     
+ Partials        638      635       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ruibaby ruibaby changed the title WIP:feat: add details extension for editor feat: add details extension for editor Jun 26, 2025
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2025
Copy link

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2025
Copy link

f2c-ci-robot bot commented Jun 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit 3ac0952 into halo-dev:main Jun 26, 2025
11 checks passed
@ruibaby ruibaby deleted the feat/editor-details branch June 26, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Halo 有办法实现这种折叠效果吗?
3 participants