Skip to content

chore: refactor ui plugin bundler kit and support rsbuild #7568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 18, 2025
Merged

chore: refactor ui plugin bundler kit and support rsbuild #7568

merged 11 commits into from
Jun 18, 2025

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 17, 2025 •
edited
Loading

What type of PR is this?

/area ui
/kind feature
/area plugin
/milestone 2.21.x

What this PR does / why we need it:

This PR adds Rsbuild preset configuration support and refactors the Vite preset configuration approach for @halo-dev/ui-plugin-bundler-kit.

  • Added Rsbuild support - New rsbuildConfig function with pre-configured settings for Halo plugin development
  • Refactored Vite configuration - Improved viteConfig function with better preset handling
  • Updated documentation - Comprehensive README with usage examples and build tool comparison

example:

// Vite
import { viteConfig } from "@halo-dev/ui-plugin-bundler-kit";
export default viteConfig({ vite: { /* custom config */ } });

// Rsbuild
import { rsbuildConfig } from "@halo-dev/ui-plugin-bundler-kit";
export default rsbuildConfig({ rsbuild: { /* custom config */ } });

real-world example: guqing/plugin-metrics-graph#5

For detailed configuration options and examples, please refer to the updated README.md

⚠️ HaloUIPluginBundlerKit function is now deprecated (still functional but marked for removal)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

重构 `@halo-dev/ui-plugin-bundler-kit`，以预配置的方式为插件提供 Vite 和 Rsbuild 的构建配置。

@ruibaby
chore: refactor ui plugin bundler kit and support rsbuild
ae4cfff 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 17, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.21.x milestone Jun 17, 2025
@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. area/plugin Issues or PRs related to the Plugin Provider labels Jun 17, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and LIlGG June 17, 2025 16:13
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 17, 2025 •
edited
Loading

Open in StackBlitz

@halo-dev/api-client

npm i https://pkg.pr.new/@halo-dev/api-client@7568

@halo-dev/components

npm i https://pkg.pr.new/@halo-dev/components@7568

@halo-dev/richtext-editor

npm i https://pkg.pr.new/@halo-dev/richtext-editor@7568

@halo-dev/console-shared

npm i https://pkg.pr.new/@halo-dev/console-shared@7568

@halo-dev/ui-plugin-bundler-kit

npm i https://pkg.pr.new/@halo-dev/ui-plugin-bundler-kit@7568

commit: 449c454

@codecov Codecov
Copy link

codecov bot commented Jun 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.64%. Comparing base (42c374d) to head (449c454).
Report is 73 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #7568      +/-   ##
============================================
+ Coverage     59.55%   59.64%   +0.08%     
+ Complexity     3812     3788      -24     
============================================
  Files           677      676       -1     
  Lines         23248    23077     -171     
  Branches       1500     1483      -17     
============================================
- Hits          13846    13764      -82     
+ Misses         8764     8678      -86     
+ Partials        638      635       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ruibaby added 9 commits June 18, 2025 10:51
@ruibaby
Remove jsx plugin
eaff044 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby
Update readme
87e25fd 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby
Update readme
580705f 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby
fix ci
5d6ab93 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby
Fix rsbuild env check
11a7999 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby
Fix chunk issue
27aa0f1 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby
Fix chunk issue
84c6f60 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby
Merge branch 'main' into refactor/ui-bundler-kit
0b7af0b
@ruibaby
Refine viteConfig and rsbuildConfig
12e6892 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby ruibaby mentioned this pull request Jun 18, 2025
Merged
@ruibaby
Update outdir
449c454 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ruibaby ruibaby changed the title WIP: chore: refactor ui plugin bundler kit and support rsbuild chore: refactor ui plugin bundler kit and support rsbuild Jun 18, 2025
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 18, 2025
JohnNiang
JohnNiang approved these changes Jun 18, 2025
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2025
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit 1e5958d into halo-dev:main Jun 18, 2025
11 checks passed
@ruibaby ruibaby mentioned this pull request Jun 18, 2025
Merged
@ruibaby ruibaby deleted the refactor/ui-bundler-kit branch June 22, 2025 10:24
@ruibaby ruibaby mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang approved these changes

@guqing guqing Awaiting requested review from guqing

@LIlGG LIlGG Awaiting requested review from LIlGG

Assignees

@JohnNiang JohnNiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/plugin Issues or PRs related to the Plugin Provider area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.21.x
Development

Successfully merging this pull request may close these issues.
2 participants
@ruibaby @JohnNiang