Skip to content

feat: add custom file paths options for ui-plugin-bundler-kit #7552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2025
Merged

feat: add custom file paths options for ui-plugin-bundler-kit #7552

merged 1 commit into from
Jun 15, 2025

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 13, 2025

What type of PR is this?

/area ui
/kind improvement
/area plugin
/milestone 2.21.x

What this PR does / why we need it:

Added support for customization options to the HaloUIPluginBundlerKit.

example:

import { HaloUIPluginBundlerKit } from '@halo-dev/ui-plugin-bundler-kit';

export default {
  plugins: [
    HaloUIPluginBundlerKit({
      outDir: {
        dev: "../custom/dev/path",
        prod: "../custom/prod/path"
      },
      manifestPath: "../custom/plugin.yaml"
    })
  ]
}

Does this PR introduce a user-facing change?

`@halo-dev/ui-plugin-bundler-kit` 支持自定义 `outDir` 和 `manifestPath`。

@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 13, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.21.x milestone Jun 13, 2025
@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. area/plugin Issues or PRs related to the Plugin Provider labels Jun 13, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang June 13, 2025 15:25
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 13, 2025

Open in StackBlitz

@halo-dev/api-client

npm i https://pkg.pr.new/@halo-dev/api-client@7552

@halo-dev/components

npm i https://pkg.pr.new/@halo-dev/components@7552

@halo-dev/richtext-editor

npm i https://pkg.pr.new/@halo-dev/richtext-editor@7552

@halo-dev/console-shared

npm i https://pkg.pr.new/@halo-dev/console-shared@7552

@halo-dev/ui-plugin-bundler-kit

npm i https://pkg.pr.new/@halo-dev/ui-plugin-bundler-kit@7552

commit: daf027e

@codecov Codecov
Copy link

codecov bot commented Jun 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.63%. Comparing base (42c374d) to head (daf027e).
Report is 66 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #7552      +/-   ##
============================================
+ Coverage     59.55%   59.63%   +0.08%     
+ Complexity     3812     3787      -25     
============================================
  Files           677      676       -1     
  Lines         23248    23074     -174     
  Branches       1500     1483      -17     
============================================
- Hits          13846    13761      -85     
+ Misses         8764     8678      -86     
+ Partials        638      635       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JohnNiang
JohnNiang approved these changes Jun 15, 2025
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2025
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jun 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit 1bd6b55 into halo-dev:main Jun 15, 2025
11 checks passed
@JohnNiang JohnNiang modified the milestones: 2.21.x, 2.21.0 Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang approved these changes

@guqing guqing Awaiting requested review from guqing

Assignees

@JohnNiang JohnNiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/plugin Issues or PRs related to the Plugin Provider area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ruibaby @JohnNiang