Skip to content

feat: add support for copying full path in attachment details #7550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 13, 2025

What type of PR is this?

/area ui
/kind feature
/milestone 2.21.x

What this PR does / why we need it:

Add support for copying full path ina attachment details modal.

image

Does this PR introduce a user-facing change?

支持在附件详情弹窗中复制完整的附件地址。

ruibaby added 2 commits June 13, 2025 17:22
Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 13, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.21.x milestone Jun 13, 2025
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 13, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wan92hen June 13, 2025 09:26
Copy link

Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.63%. Comparing base (42c374d) to head (b684088).
Report is 63 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7550      +/-   ##
============================================
+ Coverage     59.55%   59.63%   +0.08%     
+ Complexity     3812     3787      -25     
============================================
  Files           677      676       -1     
  Lines         23248    23074     -174     
  Branches       1500     1483      -17     
============================================
- Hits          13846    13761      -85     
+ Misses         8764     8678      -86     
+ Partials        638      635       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2025
Copy link

f2c-ci-robot bot commented Jun 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit 15b029a into halo-dev:main Jun 13, 2025
9 checks passed
@ruibaby ruibaby modified the milestones: 2.21.x, 2.21.0 Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants