Skip to content

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 13, 2025

What type of PR is this?

/area ui
/kind improvement
/milestone 2.21.x

What this PR does / why we need it:

Adapt page header styles for responsive design

before:

image

after:

image

Which issue(s) this PR fixes:

Fixes #6425

Special notes for your reviewer:

Does this PR introduce a user-facing change?

优化移动端下文章编辑页面的样式

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 13, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.21.x milestone Jun 13, 2025
@f2c-ci-robot f2c-ci-robot bot requested a review from guqing June 13, 2025 05:17
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Jun 13, 2025
@f2c-ci-robot f2c-ci-robot bot requested a review from wan92hen June 13, 2025 05:17
Copy link

Copy link

pkg-pr-new bot commented Jun 13, 2025

Open in StackBlitz

@halo-dev/api-client

npm i https://pkg.pr.new/@halo-dev/api-client@7544

@halo-dev/components

npm i https://pkg.pr.new/@halo-dev/components@7544

@halo-dev/richtext-editor

npm i https://pkg.pr.new/@halo-dev/richtext-editor@7544

@halo-dev/console-shared

npm i https://pkg.pr.new/@halo-dev/console-shared@7544

@halo-dev/ui-plugin-bundler-kit

npm i https://pkg.pr.new/@halo-dev/ui-plugin-bundler-kit@7544

commit: 70397bd

Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.62%. Comparing base (42c374d) to head (70397bd).
Report is 58 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7544      +/-   ##
============================================
+ Coverage     59.55%   59.62%   +0.06%     
+ Complexity     3812     3785      -27     
============================================
  Files           677      676       -1     
  Lines         23248    23074     -174     
  Branches       1500     1483      -17     
============================================
- Hits          13846    13757      -89     
+ Misses         8764     8680      -84     
+ Partials        638      637       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

附件详情的 header 似乎也有类似问题,请看下面的截图:

image

@ruibaby
Copy link
Member Author

ruibaby commented Jun 13, 2025

附件详情的 header 似乎也有类似问题,请看下面的截图:

image

与这个组件没有关系

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2025
Copy link

f2c-ci-robot bot commented Jun 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit d39a571 into halo-dev:main Jun 13, 2025
11 checks passed
@ruibaby ruibaby modified the milestones: 2.21.x, 2.21.0 Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

手机端默认编辑器,好像有点不适配
2 participants