Skip to content

Provide storage policy config APIs to make it easy to use #7527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 9, 2025

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind feature
/area core
/milestone 2.21.x

What this PR does / why we need it:

This PR provides two APIs:

  1. GET /apis/console.api.storage.halo.run/v1alpha1/policies/{name}/configs/{group}
  2. PUT /apis/console.api.storage.halo.run/v1alpha1/policies/{name}/configs/{group}

It's easy to define permission control and make ui project easy to use.

Which issue(s) this PR fixes:

Fixes #7515

Does this PR introduce a user-facing change?

提供更易用的存储策略配置查询和更新接口

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 9, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.21.x milestone Jun 9, 2025
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Jun 9, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from ruibaby and wan92hen June 9, 2025 14:57
Copy link

f2c-ci-robot bot commented Jun 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign johnniang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ruibaby added 2 commits June 9, 2025 23:18
Signed-off-by: Ryan Wang <i@ryanc.cc>
Copy link

sonarqubecloud bot commented Jun 9, 2025

Copy link

pkg-pr-new bot commented Jun 9, 2025

Open in StackBlitz

@halo-dev/api-client

npm i https://pkg.pr.new/@halo-dev/api-client@7527

@halo-dev/components

npm i https://pkg.pr.new/@halo-dev/components@7527

@halo-dev/richtext-editor

npm i https://pkg.pr.new/@halo-dev/richtext-editor@7527

@halo-dev/console-shared

npm i https://pkg.pr.new/@halo-dev/console-shared@7527

@halo-dev/ui-plugin-bundler-kit

npm i https://pkg.pr.new/@halo-dev/ui-plugin-bundler-kit@7527

commit: 08397e1

@ruibaby ruibaby merged commit aeea3a5 into main Jun 9, 2025
6 of 7 checks passed
@ruibaby ruibaby deleted the feat/provide-attachment-policy-config-apis branch June 9, 2025 15:24
@ruibaby ruibaby modified the milestones: 2.21.x, 2.21.0 Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for a standard output JSON format API for ConfigMap
2 participants