Skip to content

refactor: remove time field from plugin list #7494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 1, 2025

What type of PR is this?

/area ui
/kind improvement
/milestone 2.21.x

What this PR does / why we need it:

As per the title, the time shown in the plugin list is the installation time of the plugin. For usage purposes, this time seems to have no meaning or reference value.

Which issue(s) this PR fixes:

Fixes #7493

Does this PR introduce a user-facing change?

移除插件列表的时间字段,并在插件详情中显示安装时间。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI labels Jun 1, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.21.x milestone Jun 1, 2025
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Jun 1, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wan92hen June 1, 2025 13:51
Copy link

sonarqubecloud bot commented Jun 1, 2025

Copy link

codecov bot commented Jun 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.31%. Comparing base (42c374d) to head (454aa45).
Report is 27 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7494      +/-   ##
============================================
- Coverage     59.55%   59.31%   -0.25%     
+ Complexity     3812     3750      -62     
============================================
  Files           677      675       -2     
  Lines         23248    23010     -238     
  Branches       1500     1481      -19     
============================================
- Hits          13846    13648     -198     
+ Misses         8764     8730      -34     
+ Partials        638      632       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2025
Copy link

f2c-ci-robot bot commented Jun 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit ebbe6a9 into halo-dev:main Jun 2, 2025
9 checks passed
@JohnNiang JohnNiang modified the milestones: 2.21.x, 2.21.0 Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion to Remove Time Display in Plugin List
2 participants