Skip to content

refactor: redesign ui of comment management page #7481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 6, 2025

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented May 28, 2025

What type of PR is this?

/area ui
/kind improvement
/milestone 2.21.x

What this PR does / why we need it:

This PR improves comment management UI and adds some enhancements:

  1. Optimized comment list styling for more intuitive content display

  2. Added feature to view comment details
  3. Improved review process - now shows comment details in a modal first

  4. Added support to cancel approved comments

  5. Enhanced performance for batch operations
  6. Add pending comments widget
image

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

优化评论管理的 UI,支持查看评论的详细数据。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 28, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.21.x milestone May 28, 2025
@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 28, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wan92hen May 28, 2025 07:49
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.46%. Comparing base (42c374d) to head (c601ad4).
Report is 33 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7481      +/-   ##
============================================
- Coverage     59.55%   59.46%   -0.10%     
+ Complexity     3812     3774      -38     
============================================
  Files           677      677              
  Lines         23248    23090     -158     
  Branches       1500     1482      -18     
============================================
- Hits          13846    13731     -115     
+ Misses         8764     8728      -36     
+ Partials        638      631       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ruibaby ruibaby changed the title WIP: refactor: redesign ui of comment management page refactor: redesign ui of comment management page Jun 6, 2025
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 6, 2025
ruibaby added 3 commits June 6, 2025 22:36
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Copy link

sonarqubecloud bot commented Jun 6, 2025

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2025
Copy link

f2c-ci-robot bot commented Jun 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2025
@ruibaby ruibaby merged commit 28a4a13 into halo-dev:main Jun 6, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants