Skip to content

Enable Virtual Thread when running on JVM 21 #7261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2025
Merged

Enable Virtual Thread when running on JVM 21 #7261

merged 1 commit into from
Mar 5, 2025

Conversation

JohnNiang
Copy link
Member

@JohnNiang JohnNiang commented Mar 4, 2025 •
edited by ruibaby
Loading

What type of PR is this?

/kind improvement
/area core
/milestone 2.20.x

What this PR does / why we need it:

This PR enables Virtual Thread for instances running on JVM 21. This won't affect instances running on JVM 17.

References:

Does this PR introduce a user-facing change?

为 Reconcilor 机制启用虚拟线程支持

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note-none Denotes a PR that doesn't merit a release note. labels Mar 4, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Mar 4, 2025
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Mar 4, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby March 4, 2025 11:38
@JohnNiang JohnNiang force-pushed the perf/virtual-thread branch from 472a422 to bdc67e7 Compare March 4, 2025 15:06
@JohnNiang JohnNiang force-pushed the perf/virtual-thread branch from bdc67e7 to 7b7fa47 Compare March 4, 2025 15:56
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 4, 2025

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov Codecov
Copy link

codecov bot commented Mar 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.72727% with 9 lines in your changes missing coverage. Please review.

Project coverage is 57.24%. Comparing base (eff73dc) to head (7b7fa47).
Report is 112 commits behind head on main.

Files with missing lines Patch % Lines
...lo/app/extension/controller/DefaultController.java 72.72% 5 Missing and 4 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #7261      +/-   ##
============================================
+ Coverage     56.99%   57.24%   +0.24%     
- Complexity     3999     4053      +54     
============================================
  Files           714      719       +5     
  Lines         24110    24415     +305     
  Branches       1585     1606      +21     
============================================
+ Hits          13742    13976     +234     
- Misses         9756     9816      +60     
- Partials        612      623      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ruibaby
ruibaby approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2025
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit 00c8cbb into halo-dev:main Mar 5, 2025
9 checks passed
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 10, 2025
@JohnNiang JohnNiang deleted the perf/virtual-thread branch April 2, 2025 09:31
@JohnNiang JohnNiang mentioned this pull request May 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruibaby ruibaby ruibaby approved these changes

@guqing guqing Awaiting requested review from guqing

Assignees

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.20.x
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnNiang @ruibaby