fix: move pause overlay over other overlay #3768
Conversation
css/reveal.scss
Outdated
| @@ -1073,7 +1073,7 @@ $controlsArrowAngleActive: 36deg; | |||
| background: black; | |||
| visibility: hidden; | |||
| opacity: 0; | |||
| z-index: 100; | |||
| z-index: 10001; | |||
There was a problem hiding this comment.
Instead of bumping z-index up higher, can we leave it at 100 and move the overlay down to 99? Thanks!
There was a problem hiding this comment.
Yes totally, I had that before. The reason I switch to moving the pause overlay up, was that I assume the overlay function (begin generic) has potentially being customised by users at more places, and therefore a change to the z-index could harm quit a bit. At the same time, when user have overridden the z-index of the pause overlay already, this change will not affect them.
Either way, happy to follow your recommendation.
There was a problem hiding this comment.
It's a good consideration but let's go ahead and change that anyway. It's such a small change I doubt it will affect many people.
css/reveal.scss
Outdated
| @@ -1073,7 +1073,7 @@ $controlsArrowAngleActive: 36deg; | |||
| background: black; | |||
| visibility: hidden; | |||
| opacity: 0; | |||
| z-index: 10001; | |||
| z-index: 99; | |||
There was a problem hiding this comment.
You changed the index of the pause overlay, but that should remain at 100.
The .r-overlay should move to 99 so that it appears below the pause screen.
There was a problem hiding this comment.
sorry for that, pls review once more.
|
Looks good, thanks @tobi-or-not-tobi! |
|
This has been released in 5.2.1 🚀 https://github.com/hakimel/reveal.js/releases/tag/5.2.1 |
When in an overlay, the pause overlay is behind the current overlay. With this fix, the pause-overlay moves up to the 1001 z-index and the overlay keycodes continue to work when an overlay is open.
Fixes #3766