Fixes shortcuts in overlay #3767
Conversation
|
Thanks for reporting this! Shortcuts working behind the overlay is a bug. However I prefer addressing this in the global keyboard handler so that there's a single place that provides a full overview of all key binding logic. I've addressed this in b3fd27d I'm split on whether or not the pause overlay should be allowed on top of the overlay. Currently leaning towards not allowing pause while an overlay is open but maybe there's an argument for allowing it? |
|
Cool, makes sense to handle this elsewhere. I just started to use reveal (awesome work btw!) and indeed wasn't too sure how to handle it properly. I'd say either not support it (and then it should not be done in the background) or support it properly. I'm in favour of supporting it to keep it simple for the user; the user might not even be aware he's in an overlay, he just clicks buttons/links. |
|
Okay, let's allow pausing then. Do you want to update this PR or do you want me to take care of it? |
Happy to take care of it. |
|
I'll wait for the other PR to be finished before doing so |
Thanks! The other change is not in a PR, it's already in master. |
|
Closing since the pausing overlay will be fixed in new PR |
When an overlay is active, there are a few shortcuts that don't work nicely with overlays:
z-index: 99to ensure it's below the pause element.It is also inconvenient to not have a shortcut for closing the overlay while we're in fullscreen mode; fullscreen mode will close on escape, which is a bit annoying when you want to close the overlay; shortcut "c" has been added to close the overlay.
Fixes #3766
If needed, we could make things more configurable. Also, not sure if there's better a way to leverage existing shortcut class (e.g. to get keyboard configurations).