Notes plugin: notes from data-notes attribute were not shown #3477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyboyer
commented
Sep 17, 2023
| @@ -146,7 +146,7 @@ const Plugin = () => { | |||
| } | |||
|
|
|||
| // Look for notes defined in an aside element | |||
| if( notesElements ) { | |||
| if( notesElements && notesElements.length ) { | |||
There was a problem hiding this comment.
notesElements is either null(if there is .current-fragment) or a list of elements(result of slideElement.querySelectorAll( 'aside.notes' )).
So if we have a slide:
- without fragments at all(so no
.current-fragment) - with notes specified through
data-notes
We did never see the notes because condition if( notesElements ) was always true even though list was empty
|
Good catch. Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3476 :
data-notesworked on fragment level, but not at slide level