Skip to content

add support for links to the id of an element nested inside slide #3444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 6, 2023
Merged

add support for links to the id of an element nested inside slide #3444

merged 2 commits into from
Aug 6, 2023

Conversation

t-fritsch
Copy link
Collaborator

@t-fritsch t-fritsch commented Aug 5, 2023 •
edited
Loading

Following the issue #3231, this PR adds the possibility to link to a slide by the id of an element inside it (as stated in the issue, this is especialy useful when the markup is generated by an external tool).

Usage example :

<section>
    <h2>Slide 1</h2>
    <a href="#section-id">#section-id</a> (already working)<br/>
    <a href="#nested-id">#nested-id</a> (added by this PR)<br/>
</section>
<section id="section-id">
    <h2>Slide 2</h2>
    <div>
        <div id="nested-id">some div inside the slide</div>
    <div>
</section>
more complete example (with vertical slides) 
<section>
	<a href="#section-id">#section-id</a> <br/>
	<a href="#nested-id">#nested-id</a> <br/>
	<a href="#vertical-section-id">#vertical-section-id</a> <br/>
	<a href="#vertical-nested-id-1">#vertical-nested-id-1</a> <br/>
	<a href="#vertical-section-id-2">#vertical-section-id-2</a> <br/>
	<a href="#vertical-nested-id-2">#vertical-nested-id-2</a> <br/>
</section>
<section id="section-id">
	<h2>section id</h2>
	<div id="nested-id"></div>
</section>
<section>
	<section id="vertical-section-id">
		<h2>vertical section id</h2>
		<ul>
			<li id="vertical-nested-id-1">
				vertical nested id 1
			</li>
			<li>
				<section>
					<li id="vertical-nested-id-2">
						vertical nested id 2
					</li>
				</section>
			</li>
		</ul>
	</section>
	<section id="vertical-section-id-2">
		<h2>vertical section id 2</h2>
	</section>
</section>

@hakimel hakimel merged commit b66121e into hakimel:master Aug 6, 2023
@hakimel
Copy link
Owner

hakimel commented Aug 6, 2023

Being able to link to any element by ID is a great addition. Thanks for adding that!

@anantshri anantshri mentioned this pull request Sep 12, 2023
Open
@t-fritsch t-fritsch deleted the allow-link-to-nested-element-id branch September 12, 2023 11:47
@cderv cderv mentioned this pull request Jul 23, 2024
Closed
27 tasks
cderv added a commit to quarto-dev/quarto-cli that referenced this pull request Sep 2, 2024
@cderv
revealjs 5 - Links to element in slide by id work in latest reveal.js
f8e3406 
So no need to tweak a reference by slide.

Added feature : hakimel/reveal.js#3444
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-fritsch @hakimel