Add cabal flag for static compilation #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4ab2815 to
57ff343
Compare
Adds a flag to the hadolint package that toggles static compilation. By default I set it to `false` and enable this flag in the `Dockerfile`, `appveyor.yml` and `travis.yml`. The reason is that some systems don't easily support static linking, so using the flag when you want it is nicer instead of having to patch around this problem.
57ff343 to
308f2ec
Compare
|
Thank you for your contribution! The idea behind using static binary for hadolint is that we do not have a list of dependencies/issues which are required for people to use hadolint. They can simply download binary and use it. If I understand it correctly, your change is not building static binaries if you run it locally using stack but it still does this for our releases and CI. That sounds OK to me. What do you think @lorenzo? |
|
look good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a flag to the hadolint package that toggles static compilation.
By default I set it to
falseand enable this flag in theDockerfile,appveyor.ymlandtravis.yml.The reason is that some systems don't easily support static linking,
so using the flag when you want it is nicer instead of having to patch
around this problem.
I tested locally that it "works" without setting anything and that it "breaks" (for me on NixOS) when enabling the
staticflag.We could also set the flag to
trueby default, and I would manually patch the package for NixOS, but it feels like disabling the static compilation by default is a saner default. WDYT?