Refactor main pipeline for proxy orchestration #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, remove unecessary event bindig
… into dev/smooth-h2
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the main proxy orchestration pipeline to improve handling of H2 connections from DownStream. Key changes include replacing ILocalLink with IDownStreamPipe across multiple clients, introducing an ExchangeScope parameter in several method signatures, and updating asynchronous patterns (e.g. using direct task calls and memory pool allocation).
Reviewed Changes
Copilot reviewed 43 out of 43 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Fluxzy.Core/Core/ConnectionErrorHandler.cs | Replaces exchangeInitResult with downStreamPipe and updates error message text. |
| src/Fluxzy.Core/Clients/Mock/MockedConnectionPool.cs | Updates method signature to use IDownStreamPipe and adds an ExchangeScope parameter. |
| src/Fluxzy.Core/Clients/IRemoteConnectionBuilder.cs | Refactors connection establishment to use connectResult and stream extraction from it. |
| src/Fluxzy.Core/Clients/IHttpConnectionPool.cs | Adjusts Send method signature for downstream pipe and exchange scope. |
| src/Fluxzy.Core/Clients/H2/H2ConnectionPool.cs | Removes Task.Run wrappers when starting internal read/write loops and updates buffer handling. |
| src/Fluxzy.Core/Clients/H11/* | Updates Send and Process methods to adopt IDownStreamPipe and ExchangeScope. |
| src/Fluxzy.Core/Clients/DotNetBridge/* | Introduces and disposes ExchangeScope in Http handlers. |
| src/Fluxzy.Core.Pcap/* | Refactors connection provider and connection classes for improved capture context handling. |
Comments suppressed due to low confidence (3)
src/Fluxzy.Core/Core/ConnectionErrorHandler.cs:170
- The word "occured" is misspelled. Please update it to "occurred".
var message = "A configuration error has occured.\r\n";
src/Fluxzy.Core/Clients/Mock/MockedConnectionPool.cs:42
- [nitpick] The parameter name '__' is unclear and may lead to confusion; consider using '_' to denote an unused parameter or a more descriptive name if it has a purpose.
ExchangeScope __,
src/Fluxzy.Core/Clients/H2/H2ConnectionPool.cs:118
- Removing Task.Run may change the scheduling and error propagation behavior of the read loop. Confirm that executing the loop directly (without Task.Run) is intentional and does not adversely affect concurrency or exception handling.
_innerReadTask = InternalReadLoop(_connectionToken);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this refactoring is mainly to facilitate handling H2 connection from DownStream