Skip to content

Improve Certificate Creation and Domain Resolution with Public Suffix Support and Caching #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2025

Conversation

haga-rak
Copy link
Owner

Addressing #396

  • Updated the certificate creation logic to use public suffixes for domain parsing instead of a simple dot (.) check, improving accuracy for multi-level TLDs (e.g., .co.uk).
  • Implemented a cache in the domain resolution process to improve performance, particularly in browsing scenarios where multiple requests to the same hosts occur. This optimization also reduces memory allocations. Cache can be disable with the environment variable NoCacheOnFqdnCompute=1
  • Added the public suffix list (public_suffix_list.dat) as a resource file to support accurate domain suffix detection.
  • Enabled runtime extension of known public suffixes by allowing dynamic modification of the static PublicSuffixHelper.KnownSuffixes hash set.

@haga-rak haga-rak added the bug Something isn't working label Apr 29, 2025
@haga-rak haga-rak merged commit 779639a into main Apr 29, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant