Skip to content

Feature/optional filename validation #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 30, 2020
Merged

Feature/optional filename validation #421

merged 5 commits into from
May 30, 2020

Conversation

sunxyw
Copy link
Contributor

@sunxyw sunxyw commented May 18, 2020

Make filename validation more flexible for special use cases.

I have added a switch option "validateFilename" under the "editor" in .leptonrc.

e.g. In your <homeDir>/.leptonrc

"editor": {
    "tabSize": 4,
    "validateFilename": true
},

Filename validation will be disable when "validateFilename" switch to false.

Tested on Windows10, but not tested on other platforms.

hackjutsu
hackjutsu reviewed May 22, 2020
View reviewed changes
hackjutsu
hackjutsu reviewed May 22, 2020
View reviewed changes
hackjutsu
hackjutsu reviewed May 22, 2020
View reviewed changes
@sunxyw
Copy link
Contributor Author

sunxyw commented May 22, 2020

I have moved the "required" check out of the the if (conf.get('editor').validateFilename) block.
And I have deleted some unrelated files, includes yarn-error.log, and the binary file.

Please feel free to tell me if it still has some problems or any improvement.

@hackjutsu hackjutsu merged commit 4a8cd97 into hackjutsu:master May 30, 2020
@hackjutsu
Copy link
Owner

@sunxyw Thanks for the contributions!

@hackjutsu hackjutsu mentioned this pull request May 30, 2020
Closed
@hackjutsu hackjutsu mentioned this pull request Jun 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackjutsu hackjutsu hackjutsu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunxyw @hackjutsu