Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

add some parser functionality (parse blocks and group them into global, input, general, etc...) #2

Merged
merged 6 commits into from
Nov 7, 2022
Merged

add some parser functionality (parse blocks and group them into global, input, general, etc...) #2

merged 6 commits into from
Nov 7, 2022

Conversation

flickowoa
Copy link
Member

@flickowoa flickowoa commented Nov 6, 2022 •
edited
Loading

image
is output for config

$globalvar=9999

general{
    generalconfig = 000000
    nested {
        spaces_after_labels_work_too=nested,nested
    }
}

another_block{
    another_block_contents=1
}

@NotAShelf NotAShelf self-requested a review November 6, 2022 16:06
NotAShelf
NotAShelf reviewed Nov 6, 2022
View reviewed changes
test/hyprland.conf
bind=, R, exec, $var3

bindlm=, mouse:69, resizewindow2
bindlrfuckme=, mouse:69, resizewindow2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason you removed all of those? The standard arguments (--verbose and --markdown) both depend on those to be in the test config.

NotAShelf
NotAShelf reviewed Nov 6, 2022
View reviewed changes
NotAShelf
NotAShelf reviewed Nov 6, 2022
View reviewed changes
Copy link
Member

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

@NotAShelf
Copy link
Member

And also, please use the command line flags for parsing individual config sections.
The general idea should be:

./Hyprkeys (without arguments) & ./Hyprkeys --help = example usage
./Hyprkeys --verbose = Print config options as is
./Hyprkeys --markdown = Print config options (this is mostly for binds, maybe not necessary for config values) in a markdown table.

Ideally, we should combine arguments together to get a functional output.
For example:

./Hyprkeys --binds --verbose would print only the binds, as would replacing --verbose with --markdown would print those; but in markdown.

To print out config options, please add a flag like --keywords that can be combined with --verbose or --markdown

NotAShelf
NotAShelf approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@NotAShelf NotAShelf merged commit 8d7cf9d into hyprland-community:main Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@NotAShelf NotAShelf NotAShelf approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flickowoa @NotAShelf