-
-
Notifications
You must be signed in to change notification settings - Fork 533
Nix/HM: add instructions for upstream module #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Greetings to all who come across this issue. I'm writing this to open a discussion about proceeding with migration of users to one of the new Hyprland Home-Manager modules. To bring any readers up to speed, there are currently three HM modules for Hyprland:
A tale of fragmentationTo summarize the differences between the three:
Module
|
|
For now, I encourage users to test out my module and provide feedback.
|
d3d94f4 to
93f300c
Compare
|
@fufexan Do you have any comments/suggestions about the module I made? What are your requirements for making it mainstream? |
|
@spikespaz I have a few suggestions, can you reopen your PR so I can leave comments on the code directly? |
|
@fufexan This is an entirely separate codebase, so not what you want to comment on. Open an issue on https://github.com/spikespaz/hyprland-flake and put your suggestions there. I'll have time to work on it between plane flights. |
|
Between the hm-module in the Hyprland repo and the one on HM repo which one is preferred to use? It seems that the one in home-manager has been updated more recently. edit: I ended up migrating to the module from the HM repo. IMO it could make sense to remove hm-module from the Hyprland repo and just point users to the one in home-manager. |
|
@andresilva That's up to you. I'm trying to get people to try out the one I made, as Fufexan has made room for it in his heart. If I know it works for people and can call it stable, I will move it to this Until someone besides me is using it though, I cannot do this in good conscience. |
|
Hey all! Came across this so thought I would drop my two cents: I think the best approach would be to adopt @fufexan's upstreamed hm module.
@spikespaz's module is an awesome technical feat and should absolutely be an alternative for those who are interested in a more tightly integrated solution (we should link to it in the docs). I'll for sure considering trying it out in my own setup soon(tm). In my opinion, however, it goes against the general (nixos and hm) trend of using RFC42 to make modules easier to maintain and closer to the actual config generated. RFC42 styled options are now commonplace and pretty much every single nixos/hm module uses it, including ones that manage software with configs MUCH more complex than hyprland's. In my experience, the single usecase currently awkward to handle with Hyprland's config format is weird and inconsistent, so I think fully modeling it (and keeping up with changes) is a super hard endeavour we can't assume will always be possible, so we should the simpler solution of using |
|
I think that #4004 supercedes this issue. |
Adds instructions on how to use the upstream Home Manager module for Hyprland.
Will probably undergo some changes as the HM module needs a few changes.
Fixes #272