Skip to content

fix(mcp): CORS middleware, renaming, error handling #9423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 27, 2025
Merged

fix(mcp): CORS middleware, renaming, error handling #9423

merged 6 commits into from
May 27, 2025

Conversation

matthewmcneely
Copy link
Member

@matthewmcneely matthewmcneely commented May 22, 2025 •
edited
Loading

Description

This PR:

  • Adds a CORS middleware handler to the MCP SSE server
  • Adds sanity checking for malformed MCP arguments (prevent panics)
  • Renames tools, resources and prompts to use the snake_case convention of MCP discussion
  • Uses the correct error handling for returning errors to clients
  • Adds a comprehensive integration test for the MCP SSE implementation

Note, there's a MCP demo client here that you can spin up to test the SSE implementation.

Checklist

  • Code compiles correctly and linting passes locally
  • Tests added for new functionality, or regression tests for bug fixes added as applicable

@github-actions github-actions bot added the go Pull requests that update Go code label May 22, 2025
@trunk-io Trunk.io
Copy link

trunk-io bot commented May 22, 2025

Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information.

matthewmcneely
matthewmcneely commented May 22, 2025
View reviewed changes
@github-actions github-actions bot added the area/testing Testing related issues label May 23, 2025
@matthewmcneely matthewmcneely marked this pull request as ready for review May 23, 2025 19:58
@matthewmcneely matthewmcneely requested a review from a team as a code owner May 23, 2025 19:58
@trunk-io Trunk.io
Copy link

trunk-io bot commented May 23, 2025

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@matthewmcneely matthewmcneely merged commit 003b17e into main May 27, 2025
23 checks passed
@matthewmcneely matthewmcneely deleted the matthewmcneely/mcp-updates-cors-etc branch May 27, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshil-goel harshil-goel harshil-goel approved these changes

Assignees
No one assigned
Labels
area/testing Testing related issues go Pull requests that update Go code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewmcneely @harshil-goel