Skip to content

Fix bugs in v25 RunDQL API #9388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2025
Merged

Fix bugs in v25 RunDQL API #9388

merged 2 commits into from
Apr 17, 2025

Conversation

mangalaman93
Copy link
Member

No description provided.

@Copilot Copilot AI review requested due to automatic review settings April 16, 2025 18:49
@mangalaman93 mangalaman93 requested a review from a team as a code owner April 16, 2025 18:49
@github-actions github-actions bot added the go Pull requests that update Go code label Apr 16, 2025
Copilot
Copilot AI reviewed Apr 16, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes bugs in the v25 RunDQL API by reordering operations and refining error handling.

  • Swaps the order of namespace ID extraction and DQL query parsing.
  • Updates error wrapping for DQL parsing and refines response format logic.

@mangalaman93 @Copilot
Update edgraph/query.go
2e5cab0 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@mangalaman93 mangalaman93 enabled auto-merge (squash) April 16, 2025 19:30
@trunk-io Trunk.io
Copy link

trunk-io bot commented Apr 16, 2025 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

Flaky Test Failure Summary Logs
TestLiveLoadAndExportRDFFormat Error reading from server: EOF Logs ↗︎

View Full Report ↗︎ ⋅ Docs

@mangalaman93 mangalaman93 merged commit a17fc6b into main Apr 17, 2025
13 checks passed
@mangalaman93 mangalaman93 deleted the aman/bugs branch April 17, 2025 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@harshil-goel harshil-goel harshil-goel approved these changes

Assignees
No one assigned
Labels
go Pull requests that update Go code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mangalaman93 @harshil-goel