remove telemetry from alpha and push very basic telemetry in zero #9376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes telemetry reporting from various components and defines a system namespace behavior to prevent renaming or dropping reserved namespaces.
- Removed telemetry flags from docker-compose commands and internal telemetry code calls.
- Replaced explicit checks for reserved namespaces (e.g. "root") with a common isSystemNamespace() function.
Reviewed Changes
Copilot reviewed 65 out of 67 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| graphql/testdata/custom_bench/profiling/docker-compose.yml | Removed telemetry flags from alpha and zero commands. |
| graphql/e2e/*/docker-compose.yml | Removed telemetry options from multiple docker-compose configurations. |
| edgraph/server.go | Removed telemetry posting function for alpha. |
| edgraph/namespace.go | Replaced explicit namespace checks with isSystemNamespace() function. |
| dgraphtest/dgraph.go | Removed telemetry flag adjustments in command generation for tests. |
| dgraph/docker-compose.yml | Updated alpha command telemetry configuration and added sentry flag. |
| dgraph/cmd/zero/*.go, dgraph/cmd/alpha/run.go | Removed telemetry-related code and flag usage. |
| dgraph/cmd/alpha/mutations_mode/docker-compose.yml | Removed telemetry flag from mutations mode commands. |
Files not reviewed (2)
- graphql/e2e/auth/docker-compose.yml: Language not supported
- graphql/e2e/directives/docker-compose.yml: Language not supported
da177cd to
b191d77
Compare
harshil-goel
approved these changes
Apr 23, 2025
27a8a81 to
beb8cea
Compare
harshil-goel
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.