undo the breaking change made while removing sentry flag #9364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reintroduces the default for the sentry flag that was accidentally removed, ensuring that all flags have default values as required for version v24.1.1.
- The default for the sentry flag is reintroduced in TelemetryDefaults.
- The TelemetryDefaults constant now includes an explicit sentry=false default.
Comments suppressed due to low confidence (1)
x/flags.go:16
- [nitpick] For consistency with the TraceDefaults formatting, consider adding a space between flag entries (e.g., 'reports=true; sentry=false;').
TelemetryDefaults = `reports=true;sentry=false;`
Affected versions: v24.1.1 we require a default for each flag and we removed the default value for sentry flag from the code.
77ec5ad to
14657fa
Compare
harshil-goel
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected versions: v24.1.1
we require a default for each flag and we removed the default value for sentry flag from the code.