Add API for Allocating UIDs, Timestamp and NS IDs from Zero #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds an API for UID allocation starting from zero by introducing a new AllocateUIDs RPC in the gRPC API along with its corresponding client implementation in Go.
- Implements a new function in zero.go to call the AllocateUIDs RPC.
- Updates the gRPC generated code in protos/api.v25/api.v25_grpc.pb.go to include the new AllocateUIDs method and handler.
- Adds new message definitions and RPC declaration in protos/api.v25.proto to support UID allocation.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| zero.go | Adds the AllocateUIDs client function for allocating UIDs. |
| protos/api.v25/api.v25_grpc.pb.go | Updates gRPC methods with the new AllocateUIDs implementation. |
| protos/api.v25.proto | Adds RPC declaration and message definitions for AllocateUIDs. |
Comments suppressed due to low confidence (2)
zero.go:19
- Consider adding unit or integration tests for the AllocateUIDs function to validate correct behavior of the new UID allocation API call.
func (d *Dgraph) AllocateUIDs(ctx context.Context, howMany uint64) (uint64, uint64, error) {
protos/api.v25.proto:39
- Ensure there are tests covering both the request and response messages for the AllocateUIDs RPC to validate the correctness of the proto definitions.
message AllocateUIDsRequest {
harshil-goel
previously approved these changes
Mar 13, 2025
c42dd1d to
e8c85c4
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an API to allocate UIDs, Timestamps, and Namespace IDs by adding a new AllocateIDs RPC call with corresponding proto definitions and gRPC stubs.
- Added AllocateIDs RPC with its request and response messages along with a LeaseType enum in the proto file
- Updated .trunk/trunk.yaml to upgrade the Go runtime version
- Extended the generated gRPC code with client and server implementations for the new RPC
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| protos/api.v25.proto | Adds AllocateIDs RPC, its request/response messages, and LeaseType |
| .trunk/trunk.yaml | Updates the Go runtime from 1.23.5 to 1.24.1 |
| protos/api.v25/api.v25_grpc.pb.go | Integrates AllocateIDs method into the gRPC client and server stubs |
harshil-goel
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.