Panic in gossip/gossip/algo #5169
Description
Discussed in #5167
Originally posted by dviejokfs March 6, 2025
With 3.0.0, these errors are happening more frequently
panic: runtime error: index out of range [-1]
goroutine 3305 [running]:
math/rand.(*rngSource).Uint64(0xc014386101?)
/usr/local/go/src/math/rand/rng.go:249 +0x7b
math/rand.(*Rand).Uint64(0xc0180cf980?)
/usr/local/go/src/math/rand/rand.go:104 +0x22
github.com/hyperledger/fabric/gossip/util.RandomUInt64(...)
/gossip/util/misc.go:187
github.com/hyperledger/fabric/gossip/gossip/algo.(*PullEngine).newNONCE(0xc006953000)
/gossip/gossip/algo/pull.go:324 +0x25
github.com/hyperledger/fabric/gossip/gossip/algo.(*PullEngine).initiatePull(0xc006953000)
/gossip/gossip/algo/pull.go:179 +0x11b
github.com/hyperledger/fabric/gossip/gossip/algo.NewPullEngineWithFilter.func1()
/gossip/gossip/algo/pull.go:126 +0x27
created by github.com/hyperledger/fabric/gossip/gossip/algo.NewPullEngineWithFilter in goroutine 1
/gossip/gossip/algo/pull.go:120 +0x2d5
Building a peer image from main since it changed from math/rand to math/rand/v2 seemed to have fixed the issue, but still I think needs to be fixed in 2.5.x and for 3.0.1.
I saw that @pfi79 developed this MR to change the library used for random numbers and math/rand/v2 improves concurrency use to not cause the panic. This is the MR #4995
Any suggestions?