EIP-7934 Validate block size #8765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Comment on lines
35
to
41
| public BlockSizeBlockValidator( | ||
| final BlockHeaderValidator blockHeaderValidator, | ||
| final BlockBodyValidator blockBodyValidator, | ||
| final BlockProcessor blockProcessor) { | ||
| super(blockHeaderValidator, blockBodyValidator, blockProcessor); | ||
| } | ||
|
|
There was a problem hiding this comment.
Since the limit is in the gasCalculator "for now", this class can be removed and the check can be moved to MainnetTransactionValidator.
There was a problem hiding this comment.
Rather keep it as is as in the future in this PR or another the limit being in the GasCalculator will be removed and at that point I'd want this in it's own validator.
| final boolean shouldUpdateHead, | ||
| final boolean shouldRecordBadBlock) { | ||
| final int blockSize = block.getSize(); | ||
| if (blockSize > MAX_RLP_BLOCK_SIZE) { |
There was a problem hiding this comment.
Since we have a method that returns it in the gasCalculator, it is probably better to avoid using the constant.
Comment on lines
38
to
44
| public static final int MAX_BLOCK_SIZE = 10_485_760; | ||
|
|
||
| /** The safety margin to take the CL block overhead into account */ | ||
| public static final int SAFETY_MARGIN = 2_097_152; | ||
|
|
||
| /** The maximum size of an RLP encoded block size in bytes */ | ||
| public static final int MAX_RLP_BLOCK_SIZE = MAX_BLOCK_SIZE - SAFETY_MARGIN; |
There was a problem hiding this comment.
Can be private since we have a method that returns it
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Gabriel-Trintinalia
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
EIP-7934 Validate block size
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests