Block gas limit is always positive #8736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fab-10
commented
Jun 3, 2025
| @@ -521,17 +521,10 @@ public long calculateSimulationGasCap( | |||
| } | |||
| } else { | |||
| if (rpcGasCap > 0) { | |||
| if (blockGasLimit > 0) { | |||
There was a problem hiding this comment.
block gas limit is always greater than zero, the zero case was only there because tests were not setting it
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
6f718f1 to
71c544a
Compare
9 tasks
macfarla
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR refreshes the
TransactionSimulatorTestto ensure the block gas limit is always set, this also permit to simplify theTransactionSimulatorcode to avoid the special case whenblockGasLimitis zero, that was in place only to support the unit tests, while in real world that never happens.Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests