Skip to content

fix: return BlockProcessingResult with error instead of throwing exception #8540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2025
Merged

fix: return BlockProcessingResult with error instead of throwing exception #8540

merged 2 commits into from
Apr 11, 2025

Conversation

Gabriel-Trintinalia
Copy link
Contributor

PR description

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@Gabriel-Trintinalia
Return BlockProcessingResult with error instead of throwing exception
6fe9b51 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@Gabriel-Trintinalia
Add halt reason to exception
6b6cc24 
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
@macfarla
Copy link
Contributor

macfarla commented Apr 11, 2025 •
edited
Loading

hive now shows the halt reason System call halted: Stack underflow

src/pytest_plugins/consume/hive_simulators/engine/test_via_engine.py:74: in test_blockchain_via_engine
    assert payload_response.status == (
E   AssertionError: unexpected status: status=<PayloadStatusEnum.INVALID: 'INVALID'> latest_valid_hash=b'\x0b\xdd\xf6U]1J\xd9st\x8e_\xf4\x11\x12\x03\xe8\xac\xe3\xeeLl\xbcu\xfdP\xfdr\xb7\x8b \x01' validation_error='System call halted: Stack underflow'
E   assert <PayloadStatu...ID: 'INVALID'> == <PayloadStatu...ALID: 'VALID'>

@Gabriel-Trintinalia Gabriel-Trintinalia merged commit 5438456 into hyperledger:main Apr 11, 2025
43 checks passed
@Gabriel-Trintinalia Gabriel-Trintinalia deleted the fix-invalid-return-when-request-invalid branch April 11, 2025 06:01
@Gabriel-Trintinalia Gabriel-Trintinalia changed the title Return BlockProcessingResult with error instead of throwing exception fix: return BlockProcessingResult with error instead of throwing exception Apr 11, 2025
@macfarla macfarla added the hive relating to hive tests label May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macfarla macfarla macfarla approved these changes

Assignees
No one assigned
Labels
hive relating to hive tests Prague
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gabriel-Trintinalia @macfarla