Deprecate snap server experimental option and add stable option #8512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@garyschulte are we ready to remove the --X from snap server? |
siladu
reviewed
Apr 14, 2025
besu/src/main/java/org/hyperledger/besu/cli/options/SynchronizerOptions.java
Outdated
Show resolved
Hide resolved
garyschulte
reviewed
Apr 30, 2025
| @@ -445,7 +457,7 @@ public SynchronizerConfiguration.Builder toDomainObject() { | |||
| .trienodeCountPerRequest(snapsyncTrieNodeCountPerRequest) | |||
| .localFlatAccountCountToHealPerRequest(snapsyncFlatAccountHealedCountPerRequest) | |||
| .localFlatStorageCountToHealPerRequest(snapsyncFlatStorageHealedCountPerRequest) | |||
| .isSnapServerEnabled(snapsyncServerEnabled) | |||
| .isSnapServerEnabled(snapsyncServerEnabled || snapsyncServerEnabledExperimental) | |||
There was a problem hiding this comment.
This isn't the flow we typically use when we promote something out of experimental. Typically we just alias the -X and after a quarter or so just remove the flag. We can add a deprecation message without adding an additional flag .
That said, this isn't a horrible pattern. At a minimum there needs to be a CHANGELOG.md entry for this PR, and some text in the upcoming deprecation body that references it.
6db1bf9 to
f53300f
Compare
macfarla
reviewed
May 22, 2025
added 3 commits
May 23, 2025 13:08
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
154f4ce to
048df22
Compare
macfarla
reviewed
May 25, 2025
Signed-off-by: Bhanu Pulluri <59369753+pullurib@users.noreply.github.com>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
Signed-off-by: Bhanu Pulluri <bhanu.pulluri@kaleido.io>
macfarla
reviewed
May 28, 2025
besu/src/main/java/org/hyperledger/besu/cli/options/SynchronizerOptions.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Deprecate --Xsnapsync-server-enabled and add --snapsync-server-enabled instead.
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests