Immediately check for static exceptions for SELFDESTRUCT
#8468
Conversation
|
|
||
| // checking for static violations first means fewer account accesses | ||
| if (frame.isStatic()) { | ||
| return new OperationResult(0, ExceptionalHaltReason.ILLEGAL_STATE_CHANGE); |
There was a problem hiding this comment.
Put 0 gas parameter in OperationResult.
There was a problem hiding this comment.
IMO since we are halting I can only it being useful for debugging reasons.
But even for debugging I actually don't see the point because the context failed due to an illegal state, not due to OOG. Maybe you might want to see the overall picture but what guarantees you that the developer puts in the right value, or what right value is it actually? I'll let @shemnon add to that but LGTM
There was a problem hiding this comment.
BTW CALL already does this: https://github.com/hyperledger/besu/blob/main/evm/src/main/java/org/hyperledger/besu/evm/operation/CallOperation.java#L90-L96
It just puts an arbitrary cost considering accountWarm = true.
Signed-off-by: Olivier Bégassat <olivier.begassat.cours@gmail.com>
Signed-off-by: Olivier Bégassat <olivier.begassat.cours@gmail.com>
8b796f7 to
3e26abe
Compare
PR description
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests