Skip to content

feat(CREATE): don't compute gas cost in case of staticX #8466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 9, 2025
Merged

feat(CREATE): don't compute gas cost in case of staticX #8466

merged 3 commits into from
Apr 9, 2025

Conversation

letypequividelespoubelles
Copy link
Contributor

@letypequividelespoubelles letypequividelespoubelles commented Mar 26, 2025 •
edited by ahamlat
Loading

PR description

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@letypequividelespoubelles
feat(CREATE): don't compute gas cost in case of staticX
947f30b 
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
@ahamlat
Copy link
Contributor

ahamlat commented Mar 31, 2025 •
edited
Loading

Please hold off on this PR; I'm full syncing Sepolia and Holesky to ensure there are no regressions.

@ahamlat
Copy link
Contributor

ahamlat commented Apr 8, 2025

Sepolia and Holesky full sync'ed without any issue. The improvement looks good for me.
@shemnon any concerns before I approve and merge the PR ?

@ahamlat ahamlat enabled auto-merge (squash) April 9, 2025 07:39
ahamlat
ahamlat approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@ahamlat ahamlat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahamlat ahamlat merged commit 8ceb452 into hyperledger:main Apr 9, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahamlat ahamlat ahamlat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@letypequividelespoubelles @ahamlat