Skip to content

Bonsai - check for null before clearing storage #8434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 28, 2025
Merged

Bonsai - check for null before clearing storage #8434

merged 8 commits into from
Mar 28, 2025

Conversation

macfarla
Copy link
Contributor

@macfarla macfarla commented Mar 18, 2025 •
edited
Loading

Signed-off-by: Sally MacFarlane macfarla.github@gmail.com

PR description

Fixed Issue(s)

fixes 2 hive tests from eest/consume-engine:


tests/constantinople/eip1014_create2/test_recreate.py::test_recreate[fork_Paris-blockchain_test_engine-recreate_on_separate_block_False]
tests/constantinople/eip1014_create2/test_recreate.py::test_recreate[fork_Shanghai-blockchain_test_engine-recreate_on_separate_block_False]

fixes 6 hive tests from eest/consume-rlp


tests/constantinople/eip1014_create2/test_recreate.py::test_recreate[fork_Berlin-blockchain_test-recreate_on_separate_block_False]
tests/constantinople/eip1014_create2/test_recreate.py::test_recreate[fork_ConstantinopleFix-blockchain_test-recreate_on_separate_block_False]
tests/constantinople/eip1014_create2/test_recreate.py::test_recreate[fork_Istanbul-blockchain_test-recreate_on_separate_block_False]
tests/constantinople/eip1014_create2/test_recreate.py::test_recreate[fork_London-blockchain_test-recreate_on_separate_block_False]
tests/constantinople/eip1014_create2/test_recreate.py::test_recreate[fork_Paris-blockchain_test-recreate_on_separate_block_False]
tests/constantinople/eip1014_create2/test_recreate.py::test_recreate[fork_Shanghai-blockchain_test-recreate_on_separate_block_False]

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

macfarla added 3 commits March 17, 2025 12:59
@macfarla
check for null
9db3915 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
merge
56f0d1a 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
Merge branch 'main' into null-storage-to-delete
6615d94
matkt
matkt requested changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@matkt matkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix of this PR is not good
There is already a fix for that in this pr https://github.com/hyperledger/besu/pull/7475/files#diff-35cdaa538b03c190ad53ffbd00675d0031fdd5d2bb30f88ed38296d76598fb0dR327
I recommend the fix I just shared

@matkt matkt added the bonsai label Mar 18, 2025
@macfarla
Copy link
Contributor Author

have kicked off some nodes with this branch, sepolia and holesky full/bonsai

@macfarla
Copy link
Contributor Author

Sepolia is still going (but looking similar to control).
Holesky - graph shows 2 with this PR and 1 control, all look quite similar
Screenshot 2025-03-24 at 9 48 48 am

@matkt is holesky full sync sufficient or do you want to wait for sepolia - looks like it could be another week or more?

@macfarla macfarla added the hive relating to hive tests label Mar 25, 2025
@macfarla
Copy link
Contributor Author

@matkt sepolia full sync x 2 completed (control is still going)
Screenshot 2025-03-28 at 12 08 14 pm

macfarla added 2 commits March 28, 2025 14:28
@macfarla
Merge branch 'main' of github.com:hyperledger/besu into null-storage-…
ea68a1b 
…to-delete
@macfarla
changelog
d09cffe 
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla enabled auto-merge (squash) March 28, 2025 04:30
@macfarla macfarla merged commit 35b6f01 into hyperledger:main Mar 28, 2025
43 checks passed
@macfarla macfarla deleted the null-storage-to-delete branch April 30, 2025 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matkt matkt matkt approved these changes

Assignees
No one assigned
Labels
bonsai hive relating to hive tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macfarla @matkt