Skip to content

Prevent duplicate panes in context.layout #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 11, 2024
Merged

Prevent duplicate panes in context.layout #1153

merged 2 commits into from
Nov 11, 2024

Conversation

hugsy
Copy link
Owner

@hugsy hugsy commented Nov 11, 2024

Description

Make sure panes added in context.layout have a unique name

Fixes #1145

@github-actions GitHub Actions
Copy link

🤖 Coverage update for 3776daf 🟢

Old New
Commit 0f21eea 3776daf
Score 71.2413% 71.2413% (0)

@github-actions GitHub Actions
Copy link

🤖 Coverage update for 3776daf 🔴

Old New
Commit 0f21eea 3776daf
Score 71.2413% 71.2205% (-0.0208)

@hugsy hugsy self-assigned this Nov 11, 2024
@hugsy hugsy added bug ui Anything related to GEF's appearance labels Nov 11, 2024
@hugsy hugsy added this to the next milestone Nov 11, 2024
@github-actions GitHub Actions
Copy link

🤖 Coverage update for 587f509 🟢

Old New
Commit 0f21eea 587f509
Score 71.2413% 71.2413% (0)

@github-actions GitHub Actions
Copy link

🤖 Coverage update for 587f509 🟢

Old New
Commit 0f21eea 587f509
Score 71.2413% 71.3467% (0.1054)

ValekoZ
ValekoZ approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@ValekoZ ValekoZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ValekoZ ValekoZ merged commit 3bdba58 into main Nov 11, 2024
6 checks passed
@hugsy hugsy deleted the hugsy/issue1145 branch November 11, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValekoZ ValekoZ ValekoZ approved these changes

@Grazfather Grazfather Awaiting requested review from Grazfather

@daniellimws daniellimws Awaiting requested review from daniellimws

@therealdreg therealdreg Awaiting requested review from therealdreg

@clark-ja clark-ja Awaiting requested review from clark-ja

Assignees

@hugsy hugsy

Labels
bug ui Anything related to GEF's appearance
Projects
None yet
Milestone
2025.04
Development

Successfully merging this pull request may close these issues.

Duplicate panes in context.layout
2 participants
@hugsy @ValekoZ