Skip to content

Fix prompt length calculation #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 26, 2024
Merged

Fix prompt length calculation #1103

merged 3 commits into from
May 26, 2024

Conversation

ValekoZ
Copy link
Collaborator

@ValekoZ ValekoZ commented May 13, 2024

Description

Fix bug described in #1102

Checklist

  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

@github-actions GitHub Actions
Copy link

🤖 Coverage update for 0785c26 🟢

Old New
Commit 18c1f7c 0785c26
Score 71.5629% 71.5629% (0)

Grazfather
Grazfather reviewed May 13, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

🤖 Coverage update for aac34b6 🟢

Old New
Commit 18c1f7c aac34b6
Score 71.5629% 71.5629% (0)

@hugsy
Copy link
Owner

hugsy commented May 19, 2024

@ValekoZ Can you fix the CI tests? I'll merge it afterwards

@github-actions GitHub Actions
Copy link

🤖 Coverage update for e2adb75 🟢

Old New
Commit 2c26e33 e2adb75
Score 71.4923% 71.4923% (0)

clark-ja
clark-ja approved these changes May 25, 2024
View reviewed changes
Copy link
Collaborator

@clark-ja clark-ja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

hugsy
hugsy approved these changes May 26, 2024
View reviewed changes
Copy link
Owner

@hugsy hugsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugsy hugsy merged commit bdf8219 into hugsy:main May 26, 2024
@hugsy hugsy mentioned this pull request May 26, 2024
Closed
9 tasks
@hugsy hugsy added this to the 2024.05 milestone May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Grazfather Grazfather Grazfather left review comments

@hugsy hugsy hugsy approved these changes

@clark-ja clark-ja clark-ja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2024.06
Development

Successfully merging this pull request may close these issues.
4 participants
@ValekoZ @hugsy @Grazfather @clark-ja