🤖 Coverage update for 1930e8d 🟢

Do you happen to know in which version this deprecation occured?

Update: it seems to have appeared somewhere between v9 (doesn't work) and v12 (works).
So just to ensure retro-compatibility, please update your PR by checking the version against GDB_VERSION

Do you happen to know in which version this deprecation occured?

Update: it seems to have appeared somewhere between v9 (doesn't work) and v12 (works). So just to ensure retro-compatibility, please update your PR by checking the version against GDB_VERSION

Thanks for reminding me. So do I need to add an if judgment to choose to use 'set logging on/off' or 'set logging enabled on/off' based on GDB_VERSION?

Thanks for reminding me. So do I need to add an if judgment to choose to use 'set logging on/off' or 'set logging enabled on/off' based on GDB_VERSION?

From the docs it seems that set logging enabled on/off is the way going forward so yes, it is better to simply add a if GDB_VERSION > check until our base version supported becomes one where set logging enabled on/off always works

🤖 Coverage update for b5ffba9 🟢

🤖 Coverage update for 9a14dcf 🟢

Thanks for reminding me. So do I need to add an if judgment to choose to use 'set logging on/off' or 'set logging enabled on/off' based on GDB_VERSION?

From the docs it seems that set logging enabled on/off is the way going forward so yes, it is better to simply add a if GDB_VERSION > check until our base version supported becomes one where set logging enabled on/off always works

Hi, I just added those judgments mentioned above.

@mtwoz Code formatting fails. Please fix and re-submit. Once it passes it can be merged.

@mtwoz Code formatting fails. Please fix and re-submit. Once it passes it can be merged.

OK. Thanks. I just fixed it.

🤖 Coverage update for d5e460d 🟢