Support breakpoint.locations #1068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugsy
previously requested changes
Feb 9, 2024
|
@Grazfather recommended the hasattr. Which one should I keep ?
|
|
@hugsy Do we have a decision on which check to use ? And in both cases you prefer if I remove the comments ? |
Grazfather
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If gdb is recent enough this patch uses
breakpoint.locationsto extract directly the address at which the breakpoints are set instead of parsing the command used by the user.As discussed in #1039 the previous implementation only worked if the user sets the breakpoint with a format "b *{hex(address)}"