Agent to regenerate events at a particular time or delay #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Very nice again! Could you add specs for this? |
| #either it's a time directly, or it's a json query | ||
| vp = Utils.value_at(event[:payload], options['run_at']) | ||
| vp ||= options['run_at'] | ||
| trigger_time = Time.parse(vp, now) |
There was a problem hiding this comment.
isn't now undefined in this block?
|
This is awesome. I didnt notice until recently, but since I've been running the weather agent at 4am, it's giving me weather for the next day. I need to run it the night before to get the next day's weather, but I don't want my alerts to appear on my phone until 4am the next day. My only thought is that Adding another dependency seems overkill, but https://github.com/mojombo/chronic has great natural-language processing for parsing time or timespans. |
This was referenced Jun 1, 2014
|
I've added #1055. If that meets your needs, awesome! If not, let me know and we can amend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invalidates pull request #195
The agent has three mechanisms for repeating an event: