Updating chunk and shard cache default sizes #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assafvayner
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the chunk and shard cache default size to use powers of 10 instead of powers of 2. See huggingface/huggingface_hub#3190 (comment) for background.
Note: This is my first real PR to the repo! I didn't do anything outside of:
cargo testand check to make sure there were no failing tests.If there were other steps I should've taken to validate the change, let me know!
Sidenote: Noticed while working on this that I need to update the existing huggingface_hub docs as https://linear.app/xet/issue/XET-602/document-hf-xet-shard-cache-size-limit grew out of date with the default shard cache size.