CI builds with dev, alpha, or beta tags have debug symbols and debug_assertions enabled #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lds-have-debug-symbols
bpronan
reviewed
May 28, 2025
bpronan
reviewed
May 28, 2025
| BUILD_PROFILE=opt-test | ||
| IS_RELEASE=false | ||
| else | ||
| BUILD_PROFILE=release-dbgsymbols |
There was a problem hiding this comment.
See below, this will have to branch based on whether it's windows or not. If windows, it needs to be release.
…ev-builds-have-debug-symbols
…bug-symbols' into hoytak/250528-dev-builds-have-debug-symbols
…lds-have-debug-symbols
bpronan
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the build profile and debug symbol stripping for python wheels is set based on the tag. If the tag contains dev, alpha, or beta then it builds the wheel using the opt-test profile, which enables the debug assertions within the code and without stripping out the debug symbols. All other tags keep the current release path.