Skip to content

Conversation

bpronan
Copy link
Contributor

@bpronan bpronan commented May 13, 2025

Attempting to address the sdist problems and building from source. Maturin doesn't allow for a setup like ours, so we have to workaround it for now.

We're handling the following cases here:

  1. build from source eg: pip install git+https://github.com/huggingface/xet-core.git@v1.1.1. This required the root level pyproject.toml.
  2. build and release sdist. This required the github actions edit. Since maturin replaces the root level pyproject with the one in the build directory, we need to account for the change in working directory in the project.
  3. build wheel from hf_xet: maturin doesn't allow for ../ file references, so we needed to link the LICENSE file, so that wheel build succeeds and has the proper license information.

@bpronan bpronan marked this pull request as draft May 13, 2025 22:05
@bpronan bpronan marked this pull request as ready for review May 13, 2025 22:32
@bpronan bpronan marked this pull request as draft May 13, 2025 22:47
@bpronan bpronan marked this pull request as ready for review May 13, 2025 23:00
@bpronan bpronan merged commit 098b76e into main May 14, 2025
4 checks passed
@bpronan bpronan deleted the brian/fix-sdist branch May 14, 2025 16:31
@rajatarya
Copy link
Collaborator

Love to see this, yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants