Connect detailed upload progress to hub #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been tested and verified on a draft implementation in huggingface_hub; I want to get it in now before I put up a PR there. |
seanses
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR connects detailed upload progress to the hub in a backwards compatible way.
It works by testing the number of arguments and argument names on the progress updating function. If the progress reporting function takes a single argument, this function calls it using the old method; if it has the appropriate arguments for detailed reporting --
item_id, completed_bytes, total_bytes, update_increment-- then it calls it using the new method. Additionally, if None is passed in, the progress reporting is disabled.