-
Notifications
You must be signed in to change notification settings - Fork 2.2k
📝 vLLM-integration documentation #3376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
It looks satisfactory on the whole. Can you proofread from start to finish to make sure there are no missing capitals, |
@qgallouedec Okay I guess the rendering problem is resolved now + proofread✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this nice guide @shirinyamani ! Overall it looks good with some small nits from my part :)
4c14736
to
8f02957
Compare
What does this PR do?
Document on vllm-integration
Before submitting
Pull Request section?
to it if that's the case.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.