Skip to content

🥸🔢 Adding pad_multiple to SFT trainer #3365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 26, 2025
Merged

🥸🔢 Adding pad_multiple to SFT trainer #3365

merged 6 commits into from
Apr 26, 2025

Conversation

shirinyamani
Copy link
Member

What does this PR do?

This PR is following the #3362 to give the freedom for user to be able to pad_to_multiple_of. It is tested using simple following script:

from datasets import load_dataset
from trl import SFTTrainer, SFTConfig


dataset = load_dataset("roneneldan/TinyStories", split="train[:1%]") 

config = SFTConfig(
    output_dir="sft_pad_multiple_of_2",
    max_steps=10, 
    pad_to_multiple_of=4,
    logging_steps=1,
    report_to=[],
)


if __name__ == "__main__":
    
    trainer = SFTTrainer(
        model="Qwen/Qwen2-0.5B-Instruct",
        train_dataset=dataset,
        args=config)
    trainer.train()

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@shirinyamani shirinyamani changed the title 🥸🔢pad_to_multiple_of 🥸🔢 pad_to_multiple_of Apr 25, 2025
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@qgallouedec qgallouedec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One minor suggested change.
And also please update the PR title to mention that it relates to SFT

@shirinyamani shirinyamani changed the title 🥸🔢 pad_to_multiple_of 🥸🔢 Adding pad_multiple to SFT trainer Apr 26, 2025
@shirinyamani
Copy link
Member Author

LGTM! One minor suggested change. And also please update the PR title to mention that it relates to SFT

Done!

@shirinyamani shirinyamani merged commit 8e6ed93 into main Apr 26, 2025
10 checks passed
@shirinyamani shirinyamani deleted the sft--pad branch April 26, 2025 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants