Skip to content

🎁 Reward takes completion ids #3272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 6, 2025
Merged

Conversation

qgallouedec
Copy link
Member

@qgallouedec qgallouedec commented Apr 9, 2025

This PR provides access to completion tokens in reward functions. This enables, for example, the implementation of Soft Overlong Punishment (from DAPO).

@qgallouedec qgallouedec marked this pull request as ready for review May 6, 2025 04:26
@qgallouedec qgallouedec changed the title Reward takes completion ids 🎁 Reward takes completion ids May 6, 2025
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kashif and others added 2 commits May 6, 2025 12:20
Co-authored-by: lewtun <lewis.c.tunstall@gmail.com>
Co-authored-by: lewtun <lewis.c.tunstall@gmail.com>
Copy link
Member

@shirinyamani shirinyamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I see its also well documented that its char-level not token. Great! I will close the earlier from me in favor of this then!

@qgallouedec qgallouedec merged commit 56e5766 into main May 6, 2025
9 of 10 checks passed
@qgallouedec qgallouedec deleted the pass-completion-ids-to-reward-func branch May 6, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants