-
Notifications
You must be signed in to change notification settings - Fork 2.2k
☕ Overlong-filtering for GRPO #3248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: lewtun <lewis.c.tunstall@gmail.com>
Co-authored-by: lewtun <lewis.c.tunstall@gmail.com>
Co-authored-by: lewtun <lewis.c.tunstall@gmail.com>
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's logged
🤔 hmm, any comment on how to fix it ?
The advantage calculation always takes truncated samples into account, doesn't it? |
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
There are still some minor things to do:
|
It is very surprising!! cuz I did |
tests/test_grpo_trainer.py
Outdated
learning_rate=0.1, | ||
per_device_train_batch_size=3, | ||
num_generations=3, | ||
max_completion_length=8, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious to see if the CI will pass. What I foresee is that considering the small size of the completion, all completions are truncated, so they are all filtered and the model never updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes actually the dataset in use has completions are too short, (initials are only 1 token)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Knew it!
FAILED tests/test_grpo_trainer.py::GRPOTrainerTester::test_training_with_mask_truncated_completions - AssertionError: True is not false : Parameter model.embed_tokens.weight has not changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
451bec9 should fix it
Feel free to merge, CI failing is not related to this PR |
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
What does this PR do?
changes:
simple script to take it for spin;
then do;
Before submitting
Pull Request section?
to it if that's the case.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.