Skip to content

💠 Fix multi-gpu padding free #3245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 8, 2025
Merged

💠 Fix multi-gpu padding free #3245

merged 4 commits into from
Apr 8, 2025

Conversation

qgallouedec
Copy link
Member

What does this PR do?

fixes #3244

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@qgallouedec qgallouedec mentioned this pull request Apr 6, 2025
Closed
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copilot
Copilot AI reviewed Apr 6, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

shirinyamani
shirinyamani reviewed Apr 8, 2025
View reviewed changes
Copy link
Member

@shirinyamani shirinyamani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, inspecting, you are technically setting the device same for both tensors
so device=inputs["position_ids"].device which is on the GPU so that gather works correctly?

@qgallouedec
Copy link
Member Author

CI failing is not related to this PR

@qgallouedec qgallouedec merged commit 7e17061 into main Apr 8, 2025
9 of 10 checks passed
@qgallouedec qgallouedec deleted the fix-padding-free branch April 8, 2025 18:44
yxliu-TAMU pushed a commit to mincheolseong/ECEN743-GRPO-Project-Proposal that referenced this pull request Apr 20, 2025
@qgallouedec
💠 Fix multi-gpu padding free (huggingface#3245)
5c7d3c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@shirinyamani shirinyamani shirinyamani approved these changes

@lewtun lewtun Awaiting requested review from lewtun

@kashif kashif Awaiting requested review from kashif

@edbeeching edbeeching Awaiting requested review from edbeeching

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Device Mismatch in sft_trainer.py Causing gather_for_metrics Failure
3 participants
@qgallouedec @HuggingFaceDocBuilderDev @shirinyamani