Enable number of printed completions to be set #3149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewtun
commented
Mar 24, 2025
trl/trainer/grpo_trainer.py
Outdated
| @@ -905,6 +907,8 @@ def _generate_and_score_completions( | |||
| "reward": rewards.tolist(), | |||
| } | |||
| df = pd.DataFrame(table) | |||
| if self.num_completions_to_log is not None: | |||
There was a problem hiding this comment.
For consistency, I've enabled subsampling here but we could skip it for WandB since it doesn't really matter if there's a lot of completions AFAIK
There was a problem hiding this comment.
I think for wandb we should just keep everything? It is more of an issue of the logs being spammed
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
edbeeching
reviewed
Mar 24, 2025
edbeeching
approved these changes
Mar 24, 2025
qgallouedec
reviewed
Mar 24, 2025
qgallouedec
reviewed
Mar 24, 2025
qgallouedec
reviewed
Mar 24, 2025
qgallouedec
reviewed
Mar 24, 2025
|
The CI failing is not related btw, you can safely ignore |
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
…e (don't print)" This reverts commit f6f93c7.
>>> print_prompt_completions_sample(prompts, completions, rewards, 42, -1)
>>> print_prompt_completions_sample(prompts, completions, rewards, 42, 0)
>>> print_prompt_completions_sample(prompts, completions, rewards, 42, 1)
╭────────────── Step 42 ───────────────╮
│ ┏━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━┓ │
│ ┃ Prompt ┃ Completion ┃ Reward ┃ │
│ ┡━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━┩ │
│ │ The sky is │ blue. │ 0.12 │ │
│ └────────────┴────────────┴────────┘ │
╰──────────────────────────────────────╯
>>> print_prompt_completions_sample(prompts, completions, rewards, 42, 2)
╭─────────────── Step 42 ────────────────╮
│ ┏━━━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━┓ │
│ ┃ Prompt ┃ Completion ┃ Reward ┃ │
│ ┡━━━━━━━━━━━━╇━━━━━━━━━━━━━━╇━━━━━━━━┩ │
│ │ The sky is │ blue. │ 0.12 │ │
│ ├────────────┼──────────────┼────────┤ │
│ │ The sun is │ in the sky. │ 0.69 │ │
│ └────────────┴──────────────┴────────┘ │
╰────────────────────────────────────────╯
>>> print_prompt_completions_sample(prompts, completions, rewards, 42, 3)
╭─────────────── Step 42 ────────────────╮
│ ┏━━━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━┓ │
│ ┃ Prompt ┃ Completion ┃ Reward ┃ │
│ ┡━━━━━━━━━━━━╇━━━━━━━━━━━━━━╇━━━━━━━━┩ │
│ │ The sky is │ blue. │ 0.12 │ │
│ ├────────────┼──────────────┼────────┤ │
│ │ The sun is │ in the sky. │ 0.69 │ │
│ └────────────┴──────────────┴────────┘ │
╰────────────────────────────────────────╯ |
toslali-ibm
pushed a commit
to toslali-ibm/trl
that referenced
this pull request
Mar 25, 2025
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com> Co-authored-by: Quentin Gallouédec <gallouedec.quentin@gmail.com>
kashif
pushed a commit
to kashif/trl
that referenced
this pull request
Mar 28, 2025
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com> Co-authored-by: Quentin Gallouédec <gallouedec.quentin@gmail.com>
yxliu-TAMU
pushed a commit
to mincheolseong/ECEN743-GRPO-Project-Proposal
that referenced
this pull request
Apr 20, 2025
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com> Co-authored-by: Quentin Gallouédec <gallouedec.quentin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR exposes a
num_completions_to_printarg in theGRPOConfigso that users can control how many completions are printed to the terminal. I found the default (log everything) made the logs very verbose / large.After discussing with @edbeeching I decided not to expose this for WandB since there we don't have to worry about the logs becoming overloaded.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.