Flexible_reward #3079
Merged
Flexible_reward #3079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirinyamani
commented
Mar 13, 2025
trl/trainer/simple_test.py
Outdated
There was a problem hiding this comment.
Sorry forgot to git reset this!
this was my own tiny test!
qgallouedec
reviewed
Mar 13, 2025
qgallouedec
reviewed
Mar 13, 2025
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
reviewed
Mar 13, 2025
|
What happens if none of the reward functions return a valid reward? We should add a warning, something like: # If all reward functions return None for a given row, issue a warning
if torch.isnan(rewards_per_func).all(dim=1).any():
nan_row_idx = torch.isnan(rewards_per_func).all(dim=1).nonzero(as_tuple=True)[0][0]
row_reward_kwargs = {key: value[nan_row_idx] for key, value in reward_kwargs.items()}
row_reward_kwargs["prompt"] = prompts[nan_row_idx]
row_reward_kwargs["completion"] = completions[nan_row_idx]
warnings.warn(
f"All reward functions returned None for the following kwargs: {row_reward_kwargs}. "
"Please ensure that at least one reward function returns a valid reward."
) |
|
Please also add a unittest for such case |
qgallouedec
reviewed
Mar 13, 2025
qgallouedec
reviewed
Mar 13, 2025
qgallouedec
reviewed
Mar 14, 2025
qgallouedec
reviewed
Mar 14, 2025
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
qgallouedec
reviewed
Mar 14, 2025
qgallouedec
reviewed
Mar 14, 2025
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
qgallouedec
reviewed
Mar 14, 2025
qgallouedec
reviewed
Mar 14, 2025
qgallouedec
reviewed
Mar 14, 2025
qgallouedec
reviewed
Mar 14, 2025
qgallouedec
reviewed
Mar 15, 2025
qgallouedec
reviewed
Mar 15, 2025
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
qgallouedec
reviewed
Mar 15, 2025
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
qgallouedec
reviewed
Mar 15, 2025
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
qgallouedec
reviewed
Mar 15, 2025
qgallouedec
reviewed
Mar 15, 2025
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
qgallouedec
reviewed
Mar 15, 2025
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
qgallouedec
reviewed
Mar 15, 2025
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
|
Let's see if the ci passes 🤞 |
|
You need to re-apply the pre-commits |
I did and commit the changes suggested by i, and pushed now! |
qgallouedec
reviewed
Mar 15, 2025
qgallouedec
reviewed
Mar 15, 2025
qgallouedec
approved these changes
Mar 15, 2025
yxliu-TAMU
pushed a commit
to mincheolseong/ECEN743-GRPO-Project-Proposal
that referenced
this pull request
Apr 20, 2025
Flexible_reward
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes discussion
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.