GSPO parameters update from v2 #3798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qgallouedec
reviewed
Jul 30, 2025
docs/source/paper_index.md
Outdated
| beta=0.0, # GSPO set kl regularization to zero: https://github.com/volcengine/verl/pull/2775#issuecomment-3131807306 | ||
| epsilon=3e-4, # GSPO paper (v2), section 5.1 | ||
| epsilon_high=4e-4, # GSPO paper (v2), section 5.1 | ||
| gradient_accumulation_steps=4, # partition rollout batch into 4 mini-batches. GSPO paper (v2), section 5.1 |
There was a problem hiding this comment.
Suggested change
| gradient_accumulation_steps=4, # partition rollout batch into 4 mini-batches. GSPO paper (v2), section 5.1 | |
| steps_per_generation=4, # partition rollout batch into 4 mini-batches. GSPO paper (v2), section 5.1 |
There was a problem hiding this comment.
can you also add somewhere that this value steps_per_generation should be 4x gradient_accumulation_steps
There was a problem hiding this comment.
you are right! done. thanks.
|
Oops, I missed yours, closing #3802 thanks! |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
reviewed
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the
training_argsof GSPO indocs/source/paper_index.mdto align with the hyperparameters described in the GSPO v2 paper and documented in trl/trainer/grpo_config.py.Before submitting
Pull Request section?
to it if that's the case.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@qgallouedec